Suppport for EditorConfig files with names #61
Conversation
|
This pull request depends on pull request #60 for full functionality (but no merge conflicts) |
|
Does it mean we don't need to restart the IDE anymore after loading the plugin? And do we need to reopen a project when a new |
| @@ -5,6 +5,7 @@ | |||
| public final class Settings { | |||
|
|
|||
| public static final String MIME_TYPE = "text/x-editorconfig"; // NOI18N | |||
| public static final String EXTENSION = "editorconfig"; // NOI18N | |||
There was a problem hiding this comment.
Lines marked with #NOI18N or other applicable comments on line before a given message/label or group of them denotes what items not to translate for cases where it is not completely obvious that something should not be translated.`
I doubt that we need the NOI18N declaration in a settings file because there is no translation for a MIME type, Extension and / or resource path.
There was a problem hiding this comment.
Think of an automatic approach of translating text within sourcecode (or at least separating). I don't think theres something wrong with that comment since the guys from the JDK for example do it the same way. :)
There was a problem hiding this comment.
Always keep it simple. There is NO automatic text translation right now and it makes NO sense to translate a MIME type. The documentation says you should use NOI18N when it is not completely obvious that something should not be translated and in this case it is obvious. So it's pointless to use NOI18N here.
There was a problem hiding this comment.
|
"Does it mean we don't need to restart the IDE anymore after loading the plugin?" |
|
Woohoo! Like it!! |
aligned logger statements
bennycode
changed the title
Immediately evaluate new .editorconfig files
bennycode
changed the title
immediately apply editorconfig when found + cleanup of listener structure